Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

命名空间配置下拉滚动条修改需求评审 #3928

Closed
cookiejoo opened this issue Aug 30, 2021 · 7 comments
Closed

命名空间配置下拉滚动条修改需求评审 #3928

cookiejoo opened this issue Aug 30, 2021 · 7 comments
Labels

Comments

@cookiejoo
Copy link

你的特性请求和某个问题有关吗?请描述
我们在使用apollo配置时,因配置过多,在翻找配置时浏览器没有出现下拉框滚动条,只能通过鼠标滚动轴去不停的上下滚动。
没有滚动条的情况下也不知道目前的位置在哪里,想选择其他的命名空间配置时又要不停的滚动鼠标。
这样极其不方便。

清晰简洁地描述一下你希望的解决方案
希望有显示滚动条,并且固定每个命名空间配置的高度,这样极大的方便了选择命名空间配置和当前空间配置的位置。

清晰简洁地描述一下这个特性的备选方案

本人解决方案
我修改了common-style.css 一点样式达到了该效果,是否准许我提个PR?
效果如下
2
1

@cookiejoo
Copy link
Author

主要是::-webkit-scrollbar这个样式阻止了滚动条的产生,在namespace-panel-master-tab.html中223行加了最大搞定限制为600px,这样就达到了效果,使用起来非常方便。

@nobodyiam
Copy link
Member

看下和 #3925 是否解决的是同一问题?

@cookiejoo
Copy link
Author

看下和 #3925 是否解决的是同一问题?

我看了这位兄弟的提交的代码,应该只是把滚动条显示出来没有更多变更了,因为对方没有详细的意图和截图我无法得知。
我这边是对配置框做了高度限制,在发布很多配置的时候也有这个问题,我也做了高度限制。
我的变更在内部已经发布了,用户反馈体验不错。

不知你这边怎么看这个issue,请评估能否接受这个需求,一切由你们官方决定为准。

如:改图就是多配置发布的时候没有高度的话得滚动很远,也不美观。
image

@nobodyiam
Copy link
Member

社区始终是欢迎大家贡献的,可以提交 PR 大家一起看下~

@cookiejoo
Copy link
Author

社区始终是欢迎大家贡献的,可以提交 PR 大家一起看下~

好的,我一会提交PR。

@stale
Copy link

stale bot commented Oct 9, 2021

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 9, 2021
@stale
Copy link

stale bot commented Oct 16, 2021

This issue has been automatically closed because it has not had activity in the last 7 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants