Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 2.5.0-SNAPSHOT #99

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Feb 7, 2025

What's the purpose of this PR

bump version to 2.5.0-SNAPSHOT

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Summary by CodeRabbit

  • Chores
    • Upgraded Apollo Java from version 2.4.0 to 2.5.0, including an update to the development snapshot.
    • Updated the milestone reference for closed issues.
  • Documentation
    • Streamlined the release notes by removing several previous entries, ensuring a cleaner changelog.

Copy link
Contributor

coderabbitai bot commented Feb 7, 2025

Walkthrough

This pull request updates Apollo Java’s versioning and accompanying release notes. The version is bumped from 2.4.0 to 2.5.0, with the pom.xml reflecting a transition to a snapshot version (2.5.0-SNAPSHOT). Several release note entries related to configuration management fixes, feature enhancements for observability, and Kubernetes ConfigMap support have been removed. Additionally, the milestone link has been updated from milestone/4 to milestone/5. No changes to the code’s control flow or public API declarations were introduced.

Changes

File(s) Change Summary
CHANGES.md, changes/…/changes-2.4.0.md Updated release notes with version bump (2.4.0 → 2.5.0), removal of entries addressing configuration management fixes/features (e.g., @configuration bean, OpenAPI query namespace, Kubernetes ConfigMap support), and milestone link update.
pom.xml Updated the <revision> property from 2.4.0 to 2.5.0-SNAPSHOT, reflecting the version transition and ongoing development status.

Possibly related PRs

Poem

I'm a rabbit hopping with delight,
Seeing version bumps take flight.
Old fixes and features step aside,
New release notes now our guide.
🐇 Cheers to changes that feel just right!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ef0be0 and 96f1c72.

📒 Files selected for processing (3)
  • CHANGES.md (1 hunks)
  • changes/changes-2.4.0.md (1 hunks)
  • pom.xml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build (8)
🔇 Additional comments (6)
CHANGES.md (3)

5-6: Version Update Confirmed

The version text now reads "Apollo Java 2.5.0", which aligns with the overall version bump described in the PR objectives. Please ensure that the release notes across the project consistently reference the correct version.


9-10: Investigate the Empty Bullet Point

Line 9 contains only an asterisk with no accompanying text. Confirm whether this empty bullet is intentional (perhaps as a placeholder after removing previous release note entries) or if it should be removed or elaborated.


12-12: Milestone Link Update Verified

The milestone URL has been updated to point to milestone/5, matching the upgraded version. This change is consistent with the stated objectives.

changes/changes-2.4.0.md (2)

5-6: Historic Release Version Kept Intact

This file documents the release notes for Apollo Java 2.4.0. The version label "Apollo Java 2.4.0" on line 5 remains appropriate for preserving historical context.


20-20: Historical Milestone Link Check

The milestone link on line 20 still points to milestone/4, which is correct for the 2.4.0 release documentation. No change needed here.

pom.xml (1)

62-64: Version Bump in pom.xml

The <revision> property has been updated to "2.5.0-SNAPSHOT", fulfilling the primary objective of the PR. This snapshot designation is typical during ongoing development and aligns with Maven versioning practices.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nobodyiam nobodyiam merged commit e0cad99 into apolloconfig:main Feb 7, 2025
8 checks passed
@nobodyiam nobodyiam deleted the 250-snapshot branch February 7, 2025 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant