Skip to content

Commit

Permalink
Merge #20060: refactor: fix -Wbraced-scalar-init warning in validatio…
Browse files Browse the repository at this point in the history
…n tests

82b70f1 refactor: fix -Wbraced-scalar-init warning in validation tests (fanquake)

Pull request description:

  Introduced in #20004 (fa29b5a).

  ```
  test/validation_tests.cpp:68:88: warning: braces around scalar initializer [-Wbraced-scalar-init]
      BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{{OP_TRUE}});
                                                                                         ^~~~~~~~~
  /usr/local/include/boost/test/tools/old/interface.hpp:83:6: note: expanded from macro 'BOOST_CHECK'
      (P), BOOST_TEST_STRINGIZE( P ), CHECK, CHECK_PRED, _ )
       ^
  /usr/local/include/boost/test/tools/old/interface.hpp:68:61: note: expanded from macro 'BOOST_TEST_TOOL_IMPL'
          BOOST_JOIN( BOOST_TEST_TOOL_PASS_PRED, frwd_type )( P, ARGS ),          \
                                                              ^
  /usr/local/include/boost/test/tools/old/interface.hpp:51:47: note: expanded from macro 'BOOST_TEST_TOOL_PASS_PRED2'
                                                ^
  1 warning generated.
  ```

ACKs for top commit:
  practicalswift:
    ACK 82b70f1
  MarcoFalke:
    ACK 82b70f1

Tree-SHA512: ae14acd52e2a0d370a6ee7321f257190c6a44094eb3fa5a6bd85b6bb2b4002e7784589cb34dcf78545238c33cbea38113061b2a46e092f1119731e70932fa469
  • Loading branch information
MarcoFalke committed Oct 2, 2020
2 parents 69a7380 + 82b70f1 commit a6a993a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/test/validation_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ BOOST_AUTO_TEST_CASE(signet_parse_tests)
signet_argsman.ForceSetArg("-signetchallenge", "51"); // set challenge to OP_TRUE
const auto signet_params = CreateChainParams(signet_argsman, CBaseChainParams::SIGNET);
CBlock block;
BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{{OP_TRUE}});
BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{OP_TRUE});
CScript challenge{OP_TRUE};

// empty block is invalid
Expand Down

0 comments on commit a6a993a

Please sign in to comment.