Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When changing the page size of the feedback list, always start from the first page #37

Closed
markkuriekkinen opened this issue Sep 20, 2022 · 0 comments
Assignees
Labels

Comments

@markkuriekkinen
Copy link
Contributor

When the user changes the page size in the feedback list (filter feedback form results), the page URL query parameter should be removed or set to page=1. If the user is currently on the last page, then increasing the page size will cause the 404 not found error because there are less pages in total when each page contains more list items. Returning to the first page makes sense when the user changes the page size.

I think it would be enough to just remove the page query parameter here:

params.set('paginate_by', $(this).val());

(Currently, it does not touch the page parameter. paginate_by is the size of the page, while page defines which page is opened.)

@markkuriekkinen markkuriekkinen self-assigned this Oct 14, 2022
@markkuriekkinen markkuriekkinen moved this from Todo to In Progress in A+ sprints Oct 14, 2022
Repository owner moved this from In Progress to Done in A+ sprints Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant