Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<dot.> and <with:colon> implicit escaping of angle brackets isn't working #59

Closed
apjanke opened this issue Sep 12, 2020 · 1 comment
Closed
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone

Comments

@apjanke
Copy link
Owner

apjanke commented Sep 12, 2020

Exposed by adding a roff test for angle_bracket_syntax, following #48.

Low priority - looks to me like this has been broken for a while, and nobody has noticed it or complained, which means that probably nobody is using this feature.

You can now see a warning that's issued when this syntax is encountered:

bundle exec rake test
Loaded suite /usr/local/lib/ruby/gems/2.7.0/bin/rake
Started
......................................warn: unrecognized inline tag: ["dot."]
................................
Finished in 13.540875 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------------
70 tests, 112 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------
5.17 tests/s, 8.27 assertions/s

And the text disappears from the roff output:

.P
or when \fB<WORD>\fR is enclosed in backticks\.
.P
or when \fIWORD\fR has a
@apjanke apjanke self-assigned this Sep 12, 2020
@apjanke apjanke added the bug Something isn't working label Sep 12, 2020
@apjanke apjanke added this to the The Future milestone Sep 12, 2020
@apjanke
Copy link
Owner Author

apjanke commented Jan 3, 2024

Looks like this is the same thing as #102. Closing this ticket as a dupe of that one. I think it's fixed now, and the fix was to just update the test: I don't think there actually was supposed to be implicit escaping in this case; the doco and test code seems to indicate that . and : are exceptions to the implicit escaping behavior.

@apjanke apjanke closed this as completed Jan 3, 2024
@apjanke apjanke added this to ronn-ng Jan 4, 2024
@apjanke apjanke moved this to Closed in ronn-ng Jan 4, 2024
@apjanke apjanke added the duplicate This issue or pull request already exists label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
Archived in project
Development

No branches or pull requests

1 participant