-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logging): add support for request and response logging #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ignore case comparison when comparing headers
- remove duplicate builder code from RequestLoggingConfiguration & ResponseLoggingConfiguration
…e logging configuration builder parameters
- remove unused method from the LoggerHelper.cs
Quality Gate passedIssues Measures |
Shield-Jaguar
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds the support for request and response logging in C# SDK. LoggingConfiguration exposes the ILogger instance from Microsoft.Extensions.Logging.Abstractions which the user can provide in the client configuration builder from the SDK.
If the user doesn't provide the ILogger implementation, the SDK will log the request and response using the default Console Logger implementation.
Why
To add configurable logger support in C# SDK.
Type of change
Select multiple if applicable.
Dependency Change
Checklist