Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using "First Name" "Last Name" as default values #279

Closed
cnovak opened this issue Oct 9, 2019 · 5 comments
Closed

Stop using "First Name" "Last Name" as default values #279

cnovak opened this issue Oct 9, 2019 · 5 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@cnovak
Copy link
Collaborator

cnovak commented Oct 9, 2019

  • The UID 1 user is always "Firstname" "Lastname", change that to be something better.
  • Stop using "Firstname" "Lastname", but instead use username so that the name is clear when displayed. User can always edit to fix the name.
  • We could use username in both fields, or if the username has a dot in it, split by that dot. For example, jon.doe can be Firstname: Jon, Lastname: Doe. Not perfect, but keeps us from having all kinds of "firstname lastname" accounts.

We should test:

  1. New install, UID 1
  2. What happens when there are 1 or more new accounts in Drupal but not in Edge and the Apigee Edge module gets installed?

Originally posted by @kscheirer in #276 (comment)

@arlina-espinoza arlina-espinoza added this to the 8.x-1.2 milestone Oct 9, 2019
@cnovak cnovak changed the title Stop using "First Name" "Last Name" Stop using "First Name" "Last Name" as default values Oct 14, 2019
@minnur
Copy link
Contributor

minnur commented Oct 16, 2019

@cnovak see #280

@minnur minnur added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Oct 16, 2019
@mxr576
Copy link
Contributor

mxr576 commented Oct 30, 2019

The UID 1 user is always "Firstname" "Lastname", change that to be something better.

This is something that you can easily solve in the Kickstarter, you just need to expose the First Name and Last name fields in an install profile step.

Stop using "Firstname" "Lastname", but instead use username so that the name is clear when displayed. User can always edit to fix the name.
See my suggestions here: #280 (comment)

New installations, created from the Kickstarter are the simplest because from the beginning you can enforce newly created users to fill in the First name and last name fields. (UID1 can also set this, see my suggestions above.)
The actual problem is existing Drupal installations with existing users (ex.: 10k or more). If you install the Apigee Edge module on those, when the module install happens, there is no way to run a batch and initialize all users' first name and last name fields. Although those fields must be set, otherwise users can not be sync with Apigee Edge. Using the base field is a handy solution for this problem because it just provides a default value for these fields. There is no need to run any batch update on the users before you could create developer accounts for them on Apigee Edge - which is required because otherwise, they cannot access any app-related pages in Drupal.

@trebde
Copy link

trebde commented Jan 6, 2020

Hi not sure where to leave this comment so just gonna leave it here....

We are trying to update to 8.8.0 and I'm just wondering if you are planning on releasing 8.x-1.4 within the next week? If not we can patch it for now but if you are planning on releasing soon I may hold off and just wait for the update.

Thanks for all you hard work everyone!

@cnovak
Copy link
Collaborator Author

cnovak commented Jan 6, 2020

Moved @trebde comment to new issue #316

@arunz6161 arunz6161 removed this from the 8.x-1.5 milestone Jan 27, 2020
@cnovak cnovak added duplicate This issue or pull request already exists bug Something isn't working labels Mar 11, 2020
@cnovak
Copy link
Collaborator Author

cnovak commented Mar 11, 2020

Closing as duplicate of #307 to reduce confusion

@cnovak cnovak closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants