Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The $endUnit property is missing from RatePlanRate. #58

Closed
Jaesin opened this issue Jun 24, 2019 · 1 comment · Fixed by #59
Closed

The $endUnit property is missing from RatePlanRate. #58

Jaesin opened this issue Jun 24, 2019 · 1 comment · Fixed by #59
Assignees
@arunz6161
Labels
bug Something isn't working

Comments

@Jaesin
Copy link
Contributor

Jaesin commented Jun 24, 2019

Describe the bug
When trying to load the endUnit property of the RatePlanRateRateCard and the RatePlanRateRevShare objects, the property isn't available.

To Reproduce
Load a rate plan with rates and try to access $rateCardRate->getEndUnit().

Expected behavior
$rateCardRate->getEndUnit() should return the end unit.
@Jaesin Jaesin added the bug Something isn't working label Jun 24, 2019
@Jaesin Jaesin added this to the 2.0.2 milestone Jun 24, 2019
@Jaesin
Copy link
Contributor Author

Jaesin commented Jun 24, 2019

Simple fix, no tests: gh-58_add-end-unit.patch.txt

@cnovak cnovak closed this as completed in a96e7c4 Jun 24, 2019
cnovak added a commit that referenced this issue Jun 24, 2019
@cnovak
Merge pull request #59 from Jaesin/GH-58_end-unit-property
2f9f2dc 
[Fixes #58] Add the end unit property to `RatePlanRate`.
@Jaesin Jaesin mentioned this issue Jun 24, 2019
Merged
@cnovak cnovak removed this from the 2.0.3 milestone Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunz6161 arunz6161

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fixes #58] Add the end unit property to RatePlanRate.
3 participants
@Jaesin @cnovak @arunz6161