Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiDocAccessControlHandler.php uses invalid permission. #231

Closed
dpagini opened this issue Aug 16, 2023 · 4 comments · Fixed by #233
Closed

ApiDocAccessControlHandler.php uses invalid permission. #231

dpagini opened this issue Aug 16, 2023 · 4 comments · Fixed by #233
Labels
bug Something isn't working

Comments

@dpagini
Copy link

dpagini commented Aug 16, 2023

Description

This is not a valid permission...

? AccessResult::allowedIfHasPermission($account, 'view published apidoc entities')

It looks to me like at one point, apidoc was a custom entity, but that seems like it was changed to a node.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'

Actual Behavior

What happened after the steps to reproduce.

Expected Behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Notes

Add any other context about the problem here.

Version Info

Drupal 10
Module 3.0.4

@dpagini dpagini added the bug Something isn't working label Aug 16, 2023
@shishir-intelli
Copy link
Collaborator

@dpagini ,
Thank you for addressing this issue, We will certainly investigate it.

@shishir-intelli
Copy link
Collaborator

@dpagini
The custom apidoc entity is deprecated so it will be removed in the next release.
see #84

@dpagini
Copy link
Author

dpagini commented Aug 25, 2023

I'm using 3.x already in my project... it seems to me the apidoc entity was removed a long time ago. The issue is that you're still using an "entity" permission in the above referenced file, and not the new "node permission". Does that make sense?

@shishir-intelli
Copy link
Collaborator

Correct, custom apidoc entity was removed long back however, there are still a few deprecated apidoc files present in 3x which are removed in this PR #233
Please use node apidoc. see #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants