Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Giving proxyUrl with a password that contains special characters crashes #55

Closed
jirimoravcik opened this issue Oct 8, 2021 · 1 comment
Closed

Giving proxyUrl with a password that contains special characters crashes #55

jirimoravcik opened this issue Oct 8, 2021 · 1 comment

Comments

@jirimoravcik
Copy link
Member

jirimoravcik commented Oct 8, 2021 •
edited
Loading

e.g. having proxyUrl = 'http://username:a6%[email protected]:8888'
will throw Uncaught URIError: URI malformed (see https://github.com/apify/got-scraping/blob/master/src/agent/h1-proxy-agent.ts#L21)
I think it should work even with such passwords

ref sindresorhus/got#1317
@szmarczak
Copy link
Contributor

This is correct, %6q is malformed. You need to percent-encode % as %25:

http://username:a6%[email protected]:8888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jirimoravcik @szmarczak