Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SitemapRequestList.persistState() throws when sitemap loading has finished #2672

Closed
barjin opened this issue Sep 20, 2024 · 0 comments · Fixed by #2673
Closed

bug: SitemapRequestList.persistState() throws when sitemap loading has finished #2672

barjin opened this issue Sep 20, 2024 · 0 comments · Fixed by #2673
Assignees
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@barjin
Copy link
Contributor

barjin commented Sep 20, 2024

If SitemapRequestList finishes parsing the remote sitemaps and persistState() is called, it throws an exception.

This is because after parsing the sitemaps fully, the SitemapRequestList closes the internal stream with .push(null).

When persistState() is called afterwards, the contents of the stream are read into a (persisted) list. To not mutate the internal state with persistState(), we return the stream contents back to the original stream - if the stream had been closed, this causes an exception (push after EOF).

@barjin barjin added bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. labels Sep 20, 2024
@barjin barjin self-assigned this Sep 20, 2024
@barjin barjin closed this as completed in fb2c5cd Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant