Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Tests shouldn't use drafter directly #30

Closed
honzajavorek opened this issue May 24, 2016 · 1 comment
Closed

Tests shouldn't use drafter directly #30

honzajavorek opened this issue May 24, 2016 · 1 comment

Comments

@honzajavorek
Copy link
Contributor

honzajavorek commented May 24, 2016

The only blocker now is detect-transaction-examples-test.coffee. To remove drafter with ast option and any dependency on API Blueprint AST, we need to turn the regression check to static fixtures and assert against those fixtures.

Also, there could be a script or at least a tutorial on how to generate the fixtures using old version of drafter which still supports AST, if regressions are found and new fixtures are needed.

@honzajavorek honzajavorek changed the title Tests shouldn't use protagonist directly Tests shouldn't use drafter directly Jul 17, 2017
@honzajavorek
Copy link
Contributor Author

#87 closes this. Given the arrays of numbers present in the detect-transaction-examples-test.coffee file were consistent with the behavior of the API Blueprint AST, and given these were tested, I think we can consider them as static fixtures codifying the desired behavior.

There was no need to add any tests or to fix any behavior for quite some time already, so I think it isn't necessary to document how to get additional fixtures etc. I don't think it will ever be needed, especially with the knowledge there's apiaryio/dredd#227.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant