This repository has been archived by the owner on Aug 26, 2024. It is now read-only.
Add airnode-deployer rollback command
#1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3125ea1): https://api3-docs--pr1170-deployer-rollback-u511ckx0.web.app (expires Tue, 31 Jan 2023 07:14:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d319eb7cbe610768342d5dc1b5cd1f3aed912886 |
dcroote
approved these changes
Jan 24, 2023
|
|
||
| Positionals: | ||
| deployment-id ID of the deployment (from 'list' command) [string] [required] | ||
| version-id ID of the deployment version (from 'info' command) [string] [required] |
There was a problem hiding this comment.
I wouldn't say it's critical, but the version-id argument would be clearer if it were slightly more explicit:
ID of the deployment version to rollback to
(Applies to api3dao/airnode as well...)
There was a problem hiding this comment.
Right, I'll add it 🙂
There was a problem hiding this comment.
I've updated the help messages for all the commands and added a commit to this PR. Hope you don't mind.
amarthadan
force-pushed
the
deployer-rollback
branch
from
7a4ed97 to
3125ea1
Compare
dcroote
approved these changes
Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1167