Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Clarify airnode-client provider URL when running locally #1120

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Nov 22, 2022

Closes #1119.

@github-actions
Copy link

github-actions bot commented Nov 22, 2022

Visit the preview URL for this PR (updated for commit 512b203):

https://api3-docs--pr1120-dcroote-issue1119-zw4r945o.web.app

(expires Wed, 30 Nov 2022 07:42:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d319eb7cbe610768342d5dc1b5cd1f3aed912886

@dcroote dcroote requested a review from wkande November 22, 2022 06:23
@peptide-origami
Copy link

peptide-origami commented Nov 22, 2022

Hey @dcroote, hope it's ok if I jump in here with a suggestion.

My OS is PopOs linux and I wasn't able to get the host-docker networks connected unless I used http://host.docker.internal:8545 in my airnode config in addition to --network='host' on the docker launch. As of 62a52aa, the document text reads: For windows, wsl or mac connect to http://host.docker.internal:8545 instead of 127.0.0.1. But I think it might need to be changed to specify this instruction should be used for all platforms.

What do you think? Or are other linux users able to specify 127.0.0.1 in their config & get a successful launch?

@dcroote
Copy link
Contributor Author

dcroote commented Nov 23, 2022

Hi @peptide-origami, thanks for the feedback. We actually use http://127.0.0.1:8545/ in our GitHub Actions CI end to end testing which runs Linux. Still, I'll change the wording to mention that even some Linux variants might need to use http://host.docker.internal:8545 as you describe.

@dcroote
Copy link
Contributor Author

dcroote commented Nov 23, 2022

@wkande no rush, but this is ready to merge now

Copy link
Member

@wkande wkande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@wkande wkande merged commit 8e39a37 into main Nov 24, 2022
@wkande wkande deleted the dcroote/issue1119 branch November 24, 2022 14:07
@wkande wkande added the ★ migrate Need to be added to VitePress-docs label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
★ migrate Need to be added to VitePress-docs ✔︎ mIgrated v0.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify what the provider URL should be when running airnode-client against a local chain
3 participants