AN-374: Creating an example that will fail #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
requested changes
Mar 14, 2022
|
Hi @Siegrift, I don't really know why the requester contract is missing; I'll investigate and recommit. |
Siegrift
reviewed
Mar 21, 2022
Co-authored-by: Emanuel Tesař <[email protected]>
Siegrift
reviewed
Mar 22, 2022
| return encode([{ name: 'coinId', type: 'string32', value: coinId }]); | ||
| }; | ||
|
|
||
| export const printResponse = async (requestId: string) => { |
There was a problem hiding this comment.
This function is not needed (will never be called since the request fails) but I am OK with it staying
Siegrift
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request creates a new Airnode example that is intended to fail. I only made a minor alteration to the coingecko example in all the necessary places and documented the behaviour in the readme.