Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore new solhint warnings #1871

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Ignore new solhint warnings #1871

merged 3 commits into from
Sep 4, 2023

Conversation

bbenligiray
Copy link
Member

Closes #1870

@bbenligiray bbenligiray requested a review from dcroote September 1, 2023 09:58
@bbenligiray bbenligiray self-assigned this Sep 1, 2023
dcroote
dcroote approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's just the sheeple bleating

🤣🤣🤣

I confirmed these additions are in the rules and that the CI failure is unrelated: #1872

@bbenligiray bbenligiray merged commit 022e0ff into master Sep 4, 2023
25 checks passed
@bbenligiray bbenligiray deleted the ignore-solhint-warnings branch September 4, 2023 13:18
@dcroote dcroote added this to the 0.13.0 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote approved these changes

Assignees

@bbenligiray bbenligiray

Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

CI warnings: Use Custom Errors instead of require statements
2 participants
@bbenligiray @dcroote