Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github actions CI for protocol-verification #1865

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

Ashar2shahid
Copy link
Contributor

@Ashar2shahid Ashar2shahid commented Aug 25, 2023

Protocol verification didn't seem to be working, the following changes should trigger it on packages/airnode-protocol changes

The condition:

github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository

probably never gets met because :

There's no real way of testing github actions locally other than forking and testing it there, so if the error still persists then I will opt for that route and create another PR

Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your logic here. Currently, the workflow is on only pull requests, but the if: conditionals limit it to running only for push or when originating from a fork.

@Ashar2shahid Ashar2shahid merged commit c59f68e into master Aug 26, 2023
25 checks passed
@Ashar2shahid Ashar2shahid deleted the protocol_ci_changes branch August 26, 2023 13:11
Ashar2shahid added a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants