Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10 - Fix Terraform secrets parsing & URLs propagations #1703

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

amarthadan
Copy link
Contributor

Backport of #1702

@amarthadan amarthadan requested a review from a team March 28, 2023 07:59
@amarthadan amarthadan self-assigned this Mar 28, 2023
@amarthadan amarthadan force-pushed the v0.10-terraform-fixes branch from 0a88188 to f6c13b1 Compare March 29, 2023 07:58
@amarthadan amarthadan requested a review from Siegrift March 29, 2023 08:22
@amarthadan
Copy link
Contributor Author

The failed documentation check is caused by two URLs that have been removed:

The problem is caused by removing the URLs from the README of Airnode examples. To fix this properly, each version would have to point to its source tree on GitHub which can get complicated. I would just ignore it for the v0.10 branch as it's not causing any problems.

Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@amarthadan amarthadan merged commit 6cfc8f2 into v0.10 Mar 29, 2023
@amarthadan amarthadan deleted the v0.10-terraform-fixes branch March 29, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants