Replace hardcoded deploymentId values in airnode-node tests #1653
Conversation
| expect(callApisSpy).toHaveBeenCalledWith( | ||
| [], | ||
| expect.objectContaining({ | ||
| deploymentId: expect.stringMatching(new RegExp(`local[0-9a-z]{${DEPLOYMENT_ID_LENGTH}}`)), |
There was a problem hiding this comment.
Since the regular expression is always the same we can extract it as a constant and use that instead.
Also, it can be made more strict using [0-9a-f] (only hexadecimal) instead.
There was a problem hiding this comment.
A constant across all tests? Without the local prefix? I may not be understanding how you envision this.
Also a-f, right haha.
There was a problem hiding this comment.
I've updated it to a-f and to have a const regex variable per test file. I don't think it makes sense to have it as a "global" constant because the cloud provider type prefix of local applies to these tests and wouldn't apply to aws or gcp deployment ID regexes
There was a problem hiding this comment.
I mean it as a global test constant since all the tests here use only the local prefix. But this is fine as well.
Closes #1641.
deriveDeploymentIdtakes as one argument the Airnode version. Consequently, when the Airnode version is bumped, thedeploymentIdchanges, which breaks tests that have hardcoded values. This PR replaces these hardcoded values with a regex so bumping the version no longer causes the tests to fail. Tests on the output ofderiveDeploymentIdare already present elsewhere.