Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify provider URL when running airnode-examples locally #1561

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Clarify provider URL when running airnode-examples locally #1561

merged 6 commits into from
Nov 30, 2022

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Nov 26, 2022

@dcroote dcroote self-assigned this Nov 26, 2022
@dcroote dcroote requested a review from Siegrift November 26, 2022 20:47
Siegrift
Siegrift approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

Btw. did you check if it's really the wierdness of the Pop! OS? Because it might be possible that the user installed Docker for desktop but forgot about it.

@dcroote dcroote requested a review from Siegrift November 27, 2022 22:44
Siegrift
Siegrift approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM (just one suggestion)

packages/airnode-examples/README.md Outdated Show resolved Hide resolved
@dcroote dcroote merged commit 74f33ea into master Nov 30, 2022
@dcroote dcroote deleted the minor-local-provider-url branch November 30, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcroote @Siegrift