Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies (non-major) #1483

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 3, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@changesets/changelog-github ^0.4.6 -> ^0.4.7 age adoption passing confidence
@changesets/cli ^2.24.4 -> ^2.25.0 age adoption passing confidence
@nomiclabs/hardhat-ethers (source) ^2.1.1 -> ^2.2.0 age adoption passing confidence
@nomiclabs/hardhat-etherscan (source) ^3.1.0 -> ^3.1.1 age adoption passing confidence
@types/aws-lambda (source) ^8.10.106 -> ^8.10.108 age adoption passing confidence
@types/jest (source) ^29.0.3 -> ^29.2.0 age adoption passing confidence
@types/lodash (source) ^4.14.185 -> ^4.14.186 age adoption passing confidence
@types/prompts (source) ^2.0.14 -> ^2.4.1 age adoption passing confidence
@typescript-eslint/eslint-plugin ^5.38.1 -> ^5.40.1 age adoption passing confidence
@typescript-eslint/parser ^5.38.1 -> ^5.40.1 age adoption passing confidence
dotenv ^16.0.2 -> ^16.0.3 age adoption passing confidence
eslint (source) ^8.24.0 -> ^8.25.0 age adoption passing confidence
eslint-plugin-functional ^4.4.0 -> ^4.4.1 age adoption passing confidence
eslint-plugin-jest ^27.0.4 -> ^27.1.3 age adoption passing confidence
hardhat-deploy ^0.11.15 -> ^0.11.18 age adoption passing confidence
jest (source) ^29.0.3 -> ^29.2.1 age adoption passing confidence
ts-jest (source) ^29.0.2 -> ^29.0.3 age adoption passing confidence
typescript (source) ^4.8.3 -> ^4.8.4 age adoption passing confidence
yargs (source) ^17.5.1 -> ^17.6.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 2am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/devdependencies-(non-major) branch from 24ff8e7 to 25bae5e Compare October 3, 2022 15:15
@andreogle
Copy link
Member

Another eslint-plugin-functional rule preventing this from being merged 😬 I'm personally not a fan of this stylistic rule at all. I find being explicit much easier to read.

@Siegrift what do you think?

@Siegrift
Copy link
Contributor

Siegrift commented Oct 3, 2022

I'm personally not a fan of this stylistic rule at all.

I like that rule. Reminds me of old Haskell days where this notation is common. It also reads fine to me.

@renovate renovate bot force-pushed the renovate/devdependencies-(non-major) branch 13 times, most recently from e5ca521 to b33ff6a Compare October 10, 2022 18:04
@renovate renovate bot force-pushed the renovate/devdependencies-(non-major) branch 6 times, most recently from 49d3b39 to 926b19f Compare October 15, 2022 00:26
@dcroote
Copy link
Contributor

dcroote commented Oct 16, 2022

I'm not a big fan of this rule either.

@renovate renovate bot force-pushed the renovate/devdependencies-(non-major) branch from 926b19f to 4bad27a Compare October 17, 2022 20:06
@Siegrift Siegrift requested review from andreogle and dcroote October 18, 2022 06:46
@Siegrift
Copy link
Contributor

Since using the ESlint rule is mostly a matter of style and it seems we collectively dislike the rule I've removed it.

The PR should be mergeable now.

@Siegrift Siegrift self-assigned this Oct 18, 2022
@dcroote
Copy link
Contributor

dcroote commented Oct 19, 2022

The PR should be mergeable now.

😅

Strange new set of errors:

Cannot spy the buildAndExecuteRequest property because it is not a function; undefined given instead

Yet:

export function buildAndExecuteRequest(options: BuildRequestOptions, config?: Config) {
const request = buildRequest(options);
return executeRequest(request, config);
}

@Siegrift
Copy link
Contributor

Yeah, there is a jest minor update included in this PR and something seems to be broken because of that. I'll be working on this (I've already assigned it myself) once I get the high-priority stuff done.

@Siegrift
Copy link
Contributor

There was a bug in Jest and a new patch was released recently https://github.com/facebook/jest/releases/tag/v29.2.1 which should fix the issue.

@Siegrift Siegrift force-pushed the renovate/devdependencies-(non-major) branch from 1dc3da2 to 886b33f Compare October 19, 2022 07:56
@Siegrift Siegrift force-pushed the renovate/devdependencies-(non-major) branch from 886b33f to 13b6094 Compare October 19, 2022 16:56
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM (I am approving since the changes I made are minor).

@Siegrift Siegrift merged commit 0e25e34 into master Oct 19, 2022
@Siegrift Siegrift deleted the renovate/devdependencies-(non-major) branch October 19, 2022 18:23
@dcroote
Copy link
Contributor

dcroote commented Oct 19, 2022

👍 LGTM (I am approving since the changes I made are minor).

Uh oh, looks like this reverted the axios bump in #1489

@Siegrift
Copy link
Contributor

Thanks for noticing. I must have broken something during rebase. Will create a fix.

@Siegrift Siegrift mentioned this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants