-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devDependencies (non-major) #1483
Conversation
24ff8e7
to
25bae5e
Compare
Another eslint-plugin-functional rule preventing this from being merged 😬 I'm personally not a fan of this stylistic rule at all. I find being explicit much easier to read. @Siegrift what do you think? |
I like that rule. Reminds me of old Haskell days where this notation is common. It also reads fine to me. |
e5ca521
to
b33ff6a
Compare
49d3b39
to
926b19f
Compare
I'm not a big fan of this rule either. |
926b19f
to
4bad27a
Compare
Since using the ESlint rule is mostly a matter of style and it seems we collectively dislike the rule I've removed it. The PR should be mergeable now. |
😅 Strange new set of errors: Cannot spy the buildAndExecuteRequest property because it is not a function; undefined given instead Yet: airnode/packages/airnode-adapter/src/request-building/execution.ts Lines 15 to 18 in d23503a
|
Yeah, there is a jest minor update included in this PR and something seems to be broken because of that. I'll be working on this (I've already assigned it myself) once I get the high-priority stuff done. |
There was a bug in Jest and a new patch was released recently https://github.com/facebook/jest/releases/tag/v29.2.1 which should fix the issue. |
1dc3da2
to
886b33f
Compare
886b33f
to
13b6094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM (I am approving since the changes I made are minor).
Uh oh, looks like this reverted the axios bump in #1489 |
Thanks for noticing. I must have broken something during rebase. Will create a fix. |
This PR contains the following updates:
^0.4.6
->^0.4.7
^2.24.4
->^2.25.0
^2.1.1
->^2.2.0
^3.1.0
->^3.1.1
^8.10.106
->^8.10.108
^29.0.3
->^29.2.0
^4.14.185
->^4.14.186
^2.0.14
->^2.4.1
^5.38.1
->^5.40.1
^5.38.1
->^5.40.1
^16.0.2
->^16.0.3
^8.24.0
->^8.25.0
^4.4.0
->^4.4.1
^27.0.4
->^27.1.3
^0.11.15
->^0.11.18
^29.0.3
->^29.2.1
^29.0.2
->^29.0.3
^4.8.3
->^4.8.4
^17.5.1
->^17.6.0
Configuration
📅 Schedule: Branch creation - "before 2am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.