Add config validation for local Airnode invocation including airnode-client container
#1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarthadan
commented
May 19, 2022
Siegrift
requested changes
May 19, 2022
amarthadan
force-pushed
the
validator-airnode-client
branch
2 times, most recently
from
49d7bc5 to
5f70853
Compare
Siegrift
reviewed
May 19, 2022
packages/airnode-node/package.json
Outdated
| @@ -28,6 +28,7 @@ | |||
| "@api3/airnode-protocol": "^0.6.0", | |||
| "@api3/airnode-utilities": "^0.6.0", | |||
| "@api3/airnode-validator": "^0.6.0", | |||
| "@api3/promise-utils": "^0.3.0", | |||
There was a problem hiding this comment.
Are we using it somewhere?
There was a problem hiding this comment.
I initially was but ended up not using it and forget to remove it. Will do.
amarthadan
force-pushed
the
validator-airnode-client
branch
from
5f70853 to
e4c1a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AN-595
Doing the config file validation separately (instead of running it as a part of
invoke.ts) so that if it fails, the container fails as well instead of running and throwing an error every minute.