Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.5]: Fix condition for enabling GCP API gateway service #1046

Merged
merged 1 commit into from
Apr 29, 2022
Merged

[v0.5]: Fix condition for enabling GCP API gateway service #1046

merged 1 commit into from
Apr 29, 2022

Conversation

amarthadan
Copy link
Contributor

Applies #1044 to the 0.5 release.

@amarthadan amarthadan requested a review from a team April 28, 2022 06:43
@amarthadan amarthadan self-assigned this Apr 28, 2022
Siegrift
Siegrift approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM (but I didn't test this).

@kolenic-martin can test these out together with the other GCP patched PRs.

@amarthadan amarthadan merged commit c67eb94 into v0.5 Apr 29, 2022
@amarthadan amarthadan deleted the v0.5-fix-gcp-gateway-service-condition branch April 29, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@amarthadan amarthadan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarthadan @Siegrift