Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create maker commands to generate data providers and data persisters #3849

Closed
dunglas opened this issue Nov 26, 2020 · 4 comments · Fixed by #3850
Closed

Create maker commands to generate data providers and data persisters #3849

dunglas opened this issue Nov 26, 2020 · 4 comments · Fixed by #3850

Comments

@dunglas
Copy link
Member

dunglas commented Nov 26, 2020

Description

It could be nice to add two commands to MakerBundle (or to ApiPlatformBundle): make:data-provider and make:data-persister.

This would help users bringing their own persistence layer.

@GregoireHebert
Copy link
Contributor

Good idea, it could even be extended to DataTransformer, ItemQueryExtension, CollectionQueryExtension and custom filter extending AbstractContextAwareFilter .

@chalasr
Copy link
Contributor

chalasr commented Nov 26, 2020

(or to ApiPlatformBundle)

As discussed, extending maker-bundle in api-platform makes much more sense than the opposite to me.

@dunglas
Copy link
Member Author

dunglas commented Nov 26, 2020

We shouldn't encourage using DataTransformer (data transformers are very often misused). +1 for the other classes.

@LebzoDev
Copy link

Instead of creating a persister file and customing it, it would be better to have one command to generate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants