Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing beforeZoom, beforeResetZoom events #229

Closed
iz-maersk opened this issue May 9, 2023 · 9 comments
Closed

Missing beforeZoom, beforeResetZoom events #229

iz-maersk opened this issue May 9, 2023 · 9 comments

Comments

@iz-maersk
Copy link

Hi! As was mentioned in previous issues, not all events were presented here. Could you please take a look into it, to have the ability to use these events for example to set the initial zoom (https://codepen.io/apexcharts/pen/BaKXaQB?editors=0010)? Thanks a lot!

@iz-maersk
Copy link
Author

@joadan
Copy link
Member

joadan commented May 22, 2023

I will start working on this now

@thirstyape
Copy link
Contributor

Added in #290, PR sent in

@joadan
Copy link
Member

joadan commented Sep 18, 2023

@thirstyape, This will only work in WASM and I don't see how we can support this in blazor server, or what do you think?
Regards Joakim

@thirstyape
Copy link
Contributor

Ok, I can try to do some more testing a bit later. I had not thought about that difference and happened to be doing my tests in WASM.

Might need to add some more documentation to indicate that.

@joadan
Copy link
Member

joadan commented Sep 18, 2023

The challenge here is we need to use invokeMethodAsync in order to support both WASM and server.
However here we are in syncronous javascript function and then it's not straight forward to wait for a result from an async method.

Same problem here: https://apexcharts.github.io/Blazor-ApexCharts/features/formatters#use%20dotnet

@joadan
Copy link
Member

joadan commented Sep 18, 2023

I'll add some documentation and a guard for now and then we can revisit.

@thirstyape
Copy link
Contributor

Good to know it is a sync/async issue, I had been looking at the JS a little to see if async would be possible in certain areas.

@joadan
Copy link
Member

joadan commented Sep 18, 2023

Fixed in v1.1.0

@joadan joadan closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants