-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add is valid and revoke methods #65
feat: add is valid and revoke methods #65
Conversation
Oh sorry! I mess something in the build... I'm on it |
0a99696
to
903469e
Compare
Ok the problem was due to a missing polyfill for Still a problem occures which break some test codes I try to write : So if you don't mind, for now I quote the tests I'm talking about (I can remove them for the sake of clarity), and if you are interested in, I can create a new pull request trying to update all dependencies and the test env? Do you mind if I changed with the recommended test-runner jest? |
903469e
to
72d5de7
Compare
thanks for the PR. I can look the coming days into the error. If you want, feel free to swap karma out for jest. I am also mostly using jest now, but back then when the package was created jest wasn't a thing xD |
Hey @NansPellicari ! |
Sure, of course ! I'm on It |
72d5de7
to
06feaea
Compare
Done! |
Hi! For my projects I had to add some features on your component (and thanks for it btw, it is really helpful to me). If you think it is usefull to you I'm glad to share!