Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add is valid and revoke methods #65

Conversation

NansPellicari
Copy link
Contributor

Hi! For my projects I had to add some features on your component (and thanks for it btw, it is really helpful to me). If you think it is usefull to you I'm glad to share!

@NansPellicari
Copy link
Contributor Author

Oh sorry! I mess something in the build... I'm on it

@NansPellicari NansPellicari force-pushed the feature/add-is-accepted-and-revoke-method branch from 0a99696 to 903469e Compare March 2, 2020 13:21
@NansPellicari
Copy link
Contributor Author

NansPellicari commented Mar 2, 2020

Ok the problem was due to a missing polyfill for Object.assign() on the test env.
'Cause of that, mount() function of vue-test-utils package didn't works.

Still a problem occures which break some test codes I try to write :
Probably due to a version compatibilty (I'm sorry but I am not sure, I spend hours on it but I am mostly a beginner on JS env, maybe you have a clue?), the mock creates by mount() does not listen events triggered during the component mounted.

So if you don't mind, for now I quote the tests I'm talking about (I can remove them for the sake of clarity), and if you are interested in, I can create a new pull request trying to update all dependencies and the test env? Do you mind if I changed with the recommended test-runner jest?

@NansPellicari NansPellicari force-pushed the feature/add-is-accepted-and-revoke-method branch from 903469e to 72d5de7 Compare March 2, 2020 13:59
@apertureless
Copy link
Owner

Hi @NansPellicari

thanks for the PR.
Well, yeah the dev dependencies could be quite outdated.

I can look the coming days into the error.

If you want, feel free to swap karma out for jest. I am also mostly using jest now, but back then when the package was created jest wasn't a thing xD

@apertureless
Copy link
Owner

Hey @NansPellicari !
Can you please update your PR ? I've merged the new jest test env. But now we have some merge conflicts.

@NansPellicari
Copy link
Contributor Author

Sure, of course ! I'm on It

@NansPellicari NansPellicari force-pushed the feature/add-is-accepted-and-revoke-method branch from 72d5de7 to 06feaea Compare March 30, 2020 14:13
@NansPellicari
Copy link
Contributor Author

Done!

@apertureless apertureless changed the title Feature: add is valid and revoke methods feat: add is valid and revoke methods Mar 30, 2020
@apertureless apertureless merged commit f5d23c9 into apertureless:develop Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants