-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Vue 2.7 usage - runtime errors + legacy
seems to be removed but not mentioned in migration guide
#966
Comments
The migration guide is for vue-chartjs 3 -> 4 As stated in the release notes and changelog we dropped the legacy support with vue-chartjs 5 https://github.com/apertureless/vue-chartjs/releases/tag/v5.0.0 |
@apertureless Actually, it should work with vue 2.7 cause it supports composition API. I'm researching it right now. |
@apertureless do you mean that https://vue-chartjs.org/migration-guides/#migration-from-v4-to-v5 is the migration guide 3 -> 4? also I don't see dropping support for Vue 2.x in the release notes |
Sorry misread. I thought you're talking about vue < 2.7 . |
legacy
seems to be removed but not mentioned in migration guidelegacy
seems to be removed but not mentioned in migration guide
@jacekkarczmarczyk Released in v5.0.1 |
That was quick! Thank you ;) |
I can confirm it works fine now, but I'd suggest to add to the release notes and migration guide information that for Vue 2.7 you need to remove |
Would you like to work on a fix?
Current and expected behavior
Although it's mentioned in migration guide that the package supports Vue 2.7 I have difficulties with making it working.
First - importing from
vue-chartjs/legacy
doesn't work any more:Second - importing from 'vue-chartjs' throws missing property errors, even after changing them from
chart-data
todata
etc.Reproduction
https://stackblitz.com/edit/github-tqxopy?file=src%2FApp.vue
chart.js version
4.0.1
vue-chartjs version
5.0.0
Possible solution
No response
The text was updated successfully, but these errors were encountered: