Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 2.8.3 #190

Closed
Tirke opened this issue Sep 8, 2017 · 4 comments
Closed

Regression in 2.8.3 #190

Tirke opened this issue Sep 8, 2017 · 4 comments

Comments

@Tirke
Copy link

Tirke commented Sep 8, 2017

Since you replaced lodash _.merge by a custom Object.assign call, you have a pretty bad regression on default styles because lodash ._merge does more than Object.assign (it works recursively on nested objects).

Consequence

Default styles are not correctly merge and many of my graphs look different after update. I will do my own merge for the moment but you should fix that 😄

@apertureless
Copy link
Owner

Oh yeah did not thought about nested object.
Will fix it.

@wernerm
Copy link

wernerm commented Sep 8, 2017

+1 I'm also working around it at the moment by using deepmerge (https://github.com/KyleAMathews/deepmerge)

@apertureless
Copy link
Owner

Will with fixed with #191

Replaced object.assign with deepmerge as it seems to be a nice small and lightweight lib :3

@apertureless
Copy link
Owner

Fixed with version 2.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants