Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a custom header can break table header arrows #50

Closed
aperezdc opened this issue Aug 30, 2016 · 0 comments
Closed

Using a custom header can break table header arrows #50

aperezdc opened this issue Aug 30, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@aperezdc
Copy link
Owner

The default template.html contains a <meta> tag as follows:

<meta http-equiv="content-type" content="text/html; charset=utf-8" />

This <meta> tag properly makes browsers interpret the entity reference codes for the sort arrows in the table headers as Unicode. Now, if a custom header is configured, and such a tag is not present (or the charset= is something else than utf-8), the sorting arrows won't show properly.

As an alternative, ngx-fancydex could generate the corresponding HTTP header instead, and the <meta> tag could be removed from the template. That could pose a problem when non custom headers or footers are not UTF-8, though this seems like a reasonable requirement for most cases.

Another option might be using the &uarr; and &darr; HTML entity references, which should render properly independently of the charset (hopefully).

@aperezdc aperezdc added the bug label Aug 30, 2016
@aperezdc aperezdc added this to the v0.4.2 milestone Aug 30, 2016
@aperezdc aperezdc self-assigned this Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant