Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose svc for sharding #8808

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix: expose svc for sharding #8808

merged 2 commits into from
Jan 15, 2025

Conversation

loomts
Copy link
Contributor

@loomts loomts commented Jan 15, 2025

@loomts loomts requested a review from a team as a code owner January 15, 2025 00:39
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.37%. Comparing base (a5bcd50) to head (0f9e2b0).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operations/expose.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8808      +/-   ##
==========================================
+ Coverage   60.28%   62.37%   +2.09%     
==========================================
  Files         376      438      +62     
  Lines       45858    56976   +11118     
==========================================
+ Hits        27645    35539    +7894     
- Misses      15614    18235    +2621     
- Partials     2599     3202     +603     
Flag Coverage Δ
unittests 62.37% <25.00%> (+2.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 15, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 15, 2025
@wangyelei wangyelei merged commit 5be65e3 into main Jan 15, 2025
36 checks passed
@wangyelei wangyelei deleted the bugfix/expose-svc-for-sharding branch January 15, 2025 08:19
@wangyelei
Copy link
Contributor

/cherry-pick release-1.0-beta

@github-actions github-actions bot added this to the Release 0.9.3 milestone Jan 15, 2025
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12784194550

apecloud-bot pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants