Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: supports incremental backup config in cluster CR #8788

Merged
merged 7 commits into from
Jan 10, 2025
Merged

fix: supports incremental backup config in cluster CR #8788

merged 7 commits into from
Jan 10, 2025

Conversation

gnolong
Copy link
Contributor

@gnolong gnolong commented Jan 10, 2025 •
edited
Loading

fix #8789

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Jan 10, 2025
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jan 10, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jan 10, 2025
@gnolong gnolong marked this pull request as ready for review January 10, 2025 08:37
@gnolong gnolong requested review from leon-inf, Y-Rookie and a team as code owners January 10, 2025 08:37
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.45%. Comparing base (4760c20) to head (5cadf0d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../apps/cluster/transformer_cluster_backup_policy.go 18.18% 8 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8788      +/-   ##
==========================================
+ Coverage   60.24%   60.45%   +0.21%     
==========================================
  Files         381      381              
  Lines       46152    46163      +11     
==========================================
+ Hits        27805    27909     +104     
+ Misses      15688    15594      -94     
- Partials     2659     2660       +1
Flag Coverage Δ
unittests 60.45% <18.18%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 10, 2025
@github-actions github-actions bot removed the size/M Denotes a PR that changes 30-99 lines. label Jan 10, 2025
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jan 10, 2025
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jan 10, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 10, 2025
@gnolong gnolong merged commit d9173ee into main Jan 10, 2025
35 checks passed
@gnolong gnolong deleted the support/specify-inc-backup-in-custer-cr branch January 10, 2025 11:15
@github-actions github-actions bot added this to the Release 0.9.2 milestone Jan 10, 2025
@gnolong gnolong mentioned this pull request Jan 10, 2025
Merged
@wangyelei
Copy link
Contributor

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12924043490

apecloud-bot pushed a commit that referenced this pull request Jan 23, 2025
@gnolong @wangyelei
fix: supports incremental backup config in cluster CR (#8788)
5e40ea4 
(cherry picked from commit d9173ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyelei wangyelei wangyelei approved these changes

@zjx20 zjx20 zjx20 approved these changes

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie Y-Rookie is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging this pull request may close these issues.

[Improvement] supports incremental backup config in cluster CRD
4 participants
@gnolong @wangyelei @apecloud-bot @zjx20