Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support to update and delete system accounts #8756

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Jan 7, 2025

No description provided.

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Jan 7, 2025
@leon-inf leon-inf force-pushed the support/system-account branch from 7afc8b9 to 74eff1d Compare January 7, 2025 06:54
@leon-inf leon-inf force-pushed the support/system-account branch from 74eff1d to 791e7a4 Compare January 7, 2025 08:33
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 67.17791% with 107 lines in your changes missing coverage. Please review.

Project coverage is 60.76%. Comparing base (fd21c31) to head (62fd592).

Files with missing lines Patch % Lines
...rs/apps/transformer_component_account_provision.go 64.15% 44 Missing and 13 partials ⚠️
controllers/apps/transformer_component_account.go 77.14% 19 Missing and 13 partials ⚠️
...llers/apps/transformer_cluster_sharding_account.go 0.00% 7 Missing ⚠️
pkg/controller/component/its_convertor.go 0.00% 4 Missing ⚠️
pkg/controller/component/component_version.go 0.00% 3 Missing ⚠️
controllers/apps/componentdefinition_controller.go 77.77% 1 Missing and 1 partial ⚠️
pkg/controller/lifecycle/lfa_account.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8756      +/-   ##
==========================================
+ Coverage   60.50%   60.76%   +0.25%     
==========================================
  Files         378      378              
  Lines       45955    46084     +129     
==========================================
+ Hits        27807    28002     +195     
+ Misses      15505    15422      -83     
- Partials     2643     2660      +17     
Flag Coverage Δ
unittests 60.76% <67.17%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Jan 8, 2025
@leon-inf leon-inf marked this pull request as ready for review January 8, 2025 08:16
@leon-inf leon-inf requested review from Y-Rookie and a team as code owners January 8, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant