Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading is not ignored. #2

Open
WalnutIT opened this issue Apr 19, 2021 · 1 comment
Open

Loading is not ignored. #2

WalnutIT opened this issue Apr 19, 2021 · 1 comment

Comments

@WalnutIT
Copy link

WalnutIT commented Apr 19, 2021

Hi,

at first good tool. Thanks for that. :)

Just recognized right now, that 'loading' is not ignored and counted as passed test.

I want to show you an example.

Output from my machine.log:

{"test":{"id":28,"name":"loading <file_path>","suiteID":27,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":1810}

Output after running flutter pub global run dart_dot_reporter machine.log:

. loading <file_path>

Hint:
I just replaced the name of the file path with a place holder.

I think the issue is, that my pathes are absolute (I am running it locally on my windows machine).

@apastuhov
Copy link
Owner

@WalnutIT sorry, but I do not have a Windows machine to test your case, please specify example of your file_path.

According to the code it should skip 'loading', actually there is a test Ignore "loading" tests to ensure that it is working. Also, it checks path via name.startsWith('loading /'). So, if it is a Windows machine there can be a different path, like C:/Program..., and validation if (name.startsWith('loading /')) { will not work.

It would be awesome, if you will find a way to define if there is a Windows or Unix path and implement it in a pull-request ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants