Bugfix for #2747 #2748
Merged
Bugfix for #2747 #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpani
reviewed
Sep 27, 2023
Comment on lines
24
to
28
| case OperEx(TlaActionOper.prime, nEx @ NameEx(name)) => | ||
| nEx.typeTag match { | ||
| case Typed(tt1: TlaType1) => state.setRex(tla.name(name + "'", tt1)) | ||
| case _ => throw new InternalCheckerError("Internal expressions should be Typed", nEx) | ||
| } |
There was a problem hiding this comment.
Do we actually need this extra check?
Feels like it only replicates the check in TlaType1.fromTypeTag, and if we wanted to be consistent, we'd need to replicate this kind of logic across all the rules?
There was a problem hiding this comment.
No, that's fair, we could just use that.
Codecov Report
@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
- Coverage 78.88% 78.86% -0.02%
==========================================
Files 464 464
Lines 15876 15876
Branches 2550 2557 +7
==========================================
- Hits 12523 12520 -3
- Misses 3353 3356 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionalitycloses #2747
No regression tests, since this error only surfaces if an intermediate expression has no rule applicable to it (as is the case in the example provided in #2747), otherwise untyped ephemeral cell expressions do not break the solver.