From b8ac5355dd9a6411306687746945f4d275aa6b73 Mon Sep 17 00:00:00 2001 From: 1ambda <1amb4a@gmail.com> Date: Sun, 19 Feb 2017 11:35:55 +0900 Subject: [PATCH] [ZEPPELIN-2105] yarn installed by frontend-maven-plugin causes build failure (BUG) ### What is this PR for? yarn installed by frontend-maven-plugin causes build failure **when there is no nodeJS in local system** To reproduce this bug - Remove system nodejs - Execute `mvn -X clean package -pl 'zeppelin-web' -DskipTests;` #### Details. - yarn installed by frontend-maven-plugin can't run commands described in scripts tag (`package.json`) - it's due to yarn uses npm when run script tags. - so we need to npm as well #### See also https://github.com/apache/zeppelin/pull/2002 https://github.com/eirslett/frontend-maven-plugin/issues/562 ### What type of PR is it? [Bug Fix] ### Todos * [x] - Rollback yarn to npm * [x] - Update README.md for zeppelin-web ### What is the Jira issue? [ZEPPELIN-2105](https://issues.apache.org/jira/browse/ZEPPELIN-2105) ### How should this be tested? - Remove system nodejs - `mvn -X clean package -pl 'zeppelin-web' -DskipTests;` ### Screenshots (if appropriate) NONE ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1amb4a@gmail.com> Closes #2016 from 1ambda/ZEPPELIN-2105/rollback-yarn-to-npm and squashes the following commits: c2affeb [1ambda] fix: Install npm as well (cherry picked from commit 4fd85f773808095a72c305a73d3e36e6f17e7514) Signed-off-by: Lee moon soo --- zeppelin-web/pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/zeppelin-web/pom.xml b/zeppelin-web/pom.xml index 5f7c2db1d99..87fcd6f22eb 100644 --- a/zeppelin-web/pom.xml +++ b/zeppelin-web/pom.xml @@ -40,6 +40,7 @@ v6.9.1 v0.18.1 + 4.2.0 UTF-8 @@ -110,10 +111,12 @@ install node and yarn install-node-and-yarn + install-node-and-npm ${node.version} ${yarn.version} + ${npm.version}