Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Runtime] Enable option to use OpenMP thread pool #4089
[Runtime] Enable option to use OpenMP thread pool #4089
Changes from 5 commits
8c96d8b
36782fb
995682e
d53403e
880f4a1
097660f
984cd50
794da1a
dd340e3
115cac5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part assumes that
need_sync==1
, which is the de facto default now, but we probably need to keep the same logical behavior with the existing thread pool. Another option is to removeneed_sync
from the code. @tqchen Do you want to talk about if we still wantneed_sync
inThreadPool::Launch()
? https://github.com/dmlc/tvm/blob/master/src/runtime/thread_pool.cc#L298There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need_sync is used to generate barriers. if we do openmp, perhaps we can ignore it and just use omp's barrier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done