-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent IR when printing R.nn.pad operator #17567
base: main
Are you sure you want to change the base?
Conversation
@tvm-bot rerun |
@Cookiee235 I do not understand the workflow completely, but it looks like some approval is needed in order to run the rest of the PR checks |
@tvm-bot rerun |
84d74e2
to
9d45cdb
Compare
fc4c7c2
to
e38971a
Compare
tests are working now, but when going from tensorflow in I tried adding transforms to |
to elaborate a bit more, originally, when pad_value was passed as positional argument, it was folded automatically, but because pad_width was actually the second positional argument, printer was broken. After I moved it to attributes, automatic folding no longer applies and it looks like legalizer is not a good place to do that because I do not see any other foldings there. Looks like the best place is in conversion from tf because other tests are green, but I tired multiple combinations and haven't found any workable, will take another look in a few days, meanwhile if you have an advice, let me know, thank you! |
Hi All,
This is a fix for #17483
the inconsistency caused by pad_width and pad_value being second argument, this PR moves pad_value to the attributes.
Let me know if that is not a proper way to resolve the issue, additionally I am not sure if there is a way to make a test for show, I would appreciate references in this case.
Thank you!