bug: don't show query overlay when panning mapbox maps #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5814 +/- ##
=======================================
Coverage 63.82% 63.82%
=======================================
Files 364 364
Lines 23099 23099
Branches 2587 2587
=======================================
Hits 14744 14744
Misses 8340 8340
Partials 15 15
Continue to review full report at Codecov.
|
Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.
xtinec
force-pushed
the
xtinec/do-not-show-overlay-when-panning-map
branch
from
56b4d81
to
cc44ec5
Compare
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 5, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also.
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also. (cherry picked from commit a411516)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* bug: don't show query overlay when panning mapbox maps Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls. * Prevent query overlay on viewport zoom also.
mistercrunch
added
🏷️ bot
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange in for viewport_latitude and viewport_longitude controls.
👀 @mistercrunch @betodealmeida