-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SqlLab] Filter out unavailable databases #3875
Conversation
Thanks for the PR! |
@mistercrunch glad to help. It's just I wasn't 100% sure about if it should be |
@dmigo @mistercrunch we sense the logic in this PR is invalid as we have Gamma role users who have access to specific datasources associated with a database but not the database itself and thus these users are no-longer able to access any of their datasources within SQL Lab. Could we either revert this PR or update the filter logic so that the whitelist set of databases were cognizant of the datasources. For the later it seems additional unit tests should be written to ensure we have coverage of various configurations. |
I'm ok either way, ask me if you want me to revert. |
@mistercrunch would you mind reverting? @dmigo would you mind updating the filter logic w/ tests in another PR. |
@john-bodley no, I don't mind. |
This reverts commit ae2205a.
This reverts commit ae2205a.
This reverts commit ae2205a.
Problem this PR solves:
One always can see the whole list of databases in sql lab. Even those he has no access to.