fix(docs): removing meta tag CSP, poking more holes in htaccess #27274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
changed the title
rusackas
commented
Feb 27, 2024
| @@ -261,7 +261,6 @@ const config = { | |||
| theme: lightCodeTheme, | |||
| darkTheme: darkCodeTheme, | |||
| }, | |||
| metadata: [{name: 'Content-Security-Policy', content: "default-src 'self'; frame-src 'https://calendar.google.com/' 'https://preset.io/' 'https://sidebar.bugherd.com/';"}], | |||
There was a problem hiding this comment.
the quotes on URLs are part of the problem, I suspect... but we need more holes poked for other stuff as well since we're apparently overriding some apache server default.
rusackas
commented
Feb 27, 2024
|
|
||
| Header set Content-Security-Policy "default-src 'self'; \ | ||
| script-src 'self'; \ | ||
| img-src 'self' https://static.scarf.sh *; \ |
There was a problem hiding this comment.
the wildcard here isn't ideal. When the bulk of the site looks OK, we can tighten the screws here.
rusackas
commented
Feb 27, 2024
| Header set Content-Security-Policy "default-src 'self'; img-src *;" | ||
|
|
||
| Header set Content-Security-Policy "default-src 'self'; \ | ||
| script-src 'self'; \ |
There was a problem hiding this comment.
Trying to avoid 'unsafe-inline' wherever possible, but we may well have to resort to it here or elsewhere.
rusackas
commented
Feb 27, 2024
docs/static/.htaccess
Outdated
| script-src-elem 'self' https://www.googletagmanager.com https://www.google-analytics.com; \ | ||
| style-src-elem 'self' https://fonts.googleapis.com; \ | ||
| font-src 'self' https://fonts.gstatic.com; \ | ||
| frame-src 'self' https://calendar.google.com https://preset.io https://sidebar.bugherd.com 'https://unpkg.com; \ |
There was a problem hiding this comment.
I don't think 'self' is needed here, but no harm no foul.
craig-rueda
approved these changes
Feb 27, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The site is not displaying things properly... and it might be because of the
htaccessfile OR themetaCSP tag... both are present. This removes the CSP meta tag, and adds more holes in thehtaccessfile. Let's see if it works! Sadly, more PRs to come, I would guess.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION