From 5e7341e6b4b6d1645d75bfabc7c64b1c9514986e Mon Sep 17 00:00:00 2001 From: "Michael S. Molina" Date: Tue, 16 Jan 2024 11:48:09 -0300 Subject: [PATCH] chore: Sets DASHBOARD_VIRTUALIZATION feature flag to True by default --- RESOURCES/FEATURE_FLAGS.md | 2 +- UPDATING.md | 1 + superset/config.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 7006a442ed915..a0eb6b0f6a320 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -42,7 +42,6 @@ These features are **finished** but currently being tested. They are usable, but - ALLOW_FULL_CSV_EXPORT - CACHE_IMPERSONATION - CONFIRM_DASHBOARD_DIFF -- DASHBOARD_VIRTUALIZATION - DRILL_BY - DRILL_TO_DETAIL - DYNAMIC_PLUGINS: [(docs)](https://superset.apache.org/docs/installation/running-on-kubernetes) @@ -66,6 +65,7 @@ These features flags are **safe for production**. They have been tested and will - ALLOW_ADHOC_SUBQUERY - DASHBOARD_CROSS_FILTERS - DASHBOARD_RBAC [(docs)](https://superset.apache.org/docs/creating-charts-dashboards/first-dashboard#manage-access-to-dashboards) +- DASHBOARD_VIRTUALIZATION - DATAPANEL_CLOSED_BY_DEFAULT - DISABLE_LEGACY_DATASOURCE_EDITOR - DRUID_JOINS diff --git a/UPDATING.md b/UPDATING.md index 18278d2029c4e..34e1646c31de4 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -33,6 +33,7 @@ assists people when migrating to a new version. - [26343](https://github.com/apache/superset/issues/26343): Removes the deprecated `ENABLE_EXPLORE_DRAG_AND_DROP` feature flag. The previous value of the feature flag was `True` and now the feature is permanently enabled. - [26331](https://github.com/apache/superset/issues/26331): Removes the deprecated `DISABLE_DATASET_SOURCE_EDIT` feature flag. The previous value of the feature flag was `False` and now the feature is permanently removed. +- [26636](https://github.com/apache/superset/issues/26636): Sets the `DASHBOARD_VIRTUALIZATION` feature flag to `True` by default. This feature was introduced by [21438](https://github.com/apache/superset/pull/21438) and will enable virtualization when rendering a dashboard's charts in an attempt to reduce the number of elements (DOM nodes) rendered at once. This is especially useful for large dashboards. ### Potential Downtime diff --git a/superset/config.py b/superset/config.py index cb76d4a029a78..206568bc16c03 100644 --- a/superset/config.py +++ b/superset/config.py @@ -446,7 +446,7 @@ class D3Format(TypedDict, total=False): # Feature is under active development and breaking changes are expected "DASHBOARD_NATIVE_FILTERS_SET": False, # deprecated "DASHBOARD_FILTERS_EXPERIMENTAL": False, # deprecated - "DASHBOARD_VIRTUALIZATION": False, + "DASHBOARD_VIRTUALIZATION": True, "GLOBAL_ASYNC_QUERIES": False, "VERSIONED_EXPORT": True, # deprecated "EMBEDDED_SUPERSET": False,