From 6e6700023a910afb95489794eb509a0aabb24062 Mon Sep 17 00:00:00 2001 From: rtexelm Date: Fri, 20 Oct 2023 16:50:25 -0400 Subject: [PATCH 1/3] Alter filter control descrip tooltip style --- .../FilterBar/FilterControls/FilterControl.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx index 515fed1907bd0..37739e5370686 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx @@ -112,6 +112,7 @@ const HorizontalOverflowFilterControlContainer = styled( const VerticalFormItem = styled(StyledFormItem)` .ant-form-item-label { + overflow: visible; label.ant-form-item-required:not(.ant-form-item-required-mark-optional) { &::after { display: none; @@ -127,6 +128,7 @@ const HorizontalFormItem = styled(StyledFormItem)` } .ant-form-item-label { + overflow: visible; padding-bottom: 0; margin-right: ${({ theme }) => theme.gridUnit * 2}px; label.ant-form-item-required:not(.ant-form-item-required-mark-optional) { @@ -200,10 +202,11 @@ const DescriptionToolTip = ({ description }: { description: string }) => ( placement="right" overlayInnerStyle={{ display: '-webkit-box', - overflow: 'hidden', - WebkitLineClamp: 20, + WebkitLineClamp: 10, WebkitBoxOrient: 'vertical', + overflow: 'hidden', textOverflow: 'ellipsis', + whiteSpace: 'normal', }} getPopupContainer={trigger => trigger.parentElement as HTMLElement} > From 92b090e266196935473df2a36f4b108045e87877 Mon Sep 17 00:00:00 2001 From: rtexelm Date: Mon, 6 Nov 2023 17:33:55 -0500 Subject: [PATCH 2/3] Increase m-width of filter label --- .../nativeFilters/FilterBar/FilterControls/FilterControl.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx index 37739e5370686..3c1f2cc40ea16 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx @@ -49,7 +49,7 @@ const VerticalFilterControlTitle = styled.h4` const HorizontalFilterControlTitle = styled(VerticalFilterControlTitle)` font-weight: ${({ theme }) => theme.typography.weights.normal}; color: ${({ theme }) => theme.colors.grayscale.base}; - max-width: ${({ theme }) => theme.gridUnit * 15}px; + max-width: ${({ theme }) => theme.gridUnit * 24}px; ${truncationCSS}; `; From 3396f4fb21e7b3e8fe76b6c73f4ec892affd3d7e Mon Sep 17 00:00:00 2001 From: Ross Mabbett <92495987+rtexelm@users.noreply.github.com> Date: Fri, 17 Nov 2023 17:51:01 -0500 Subject: [PATCH 3/3] Remove max-width from from horizontal filter labels Co-authored-by: Elizabeth Thompson --- .../nativeFilters/FilterBar/FilterControls/FilterControl.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx index 3c1f2cc40ea16..96f51f5359e13 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx @@ -49,7 +49,6 @@ const VerticalFilterControlTitle = styled.h4` const HorizontalFilterControlTitle = styled(VerticalFilterControlTitle)` font-weight: ${({ theme }) => theme.typography.weights.normal}; color: ${({ theme }) => theme.colors.grayscale.base}; - max-width: ${({ theme }) => theme.gridUnit * 24}px; ${truncationCSS}; `;