-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds the "Select all" option to the Select component #20143
Conversation
@ktmud @cccs-RyanK @lmaloney Currently, the work consisted of creating a POC to address some of the above requirements but we still have a lot of work ahead. Unfortunately, this is being deprioritized in our roadmap so I won't have much time available to continue the work right now. I'll try to continue whenever I have some time available. I'm sharing the draft PR in case anyone wants to tackle some of the efforts or contribute to the discussion. To check the POC, you just need to go to the Select Storybook. |
@michael-s-molina I have some time for this now so I plan on adding to the work you did to finish this feature. Please feel free to reach out if there is any problem with that! |
Thank you for taking a look at this! |
Hi @michael-s-molina @cccs-RyanK. This PR is extremely important. |
Hi @EugeneTorap. We're following the plan outlined here. We have completed steps 1-3 with #20466 and #20690. I think we can deliver step 4 this month, which will cover 90% of the cases. @cccs-RyanK let us know if you think otherwise. |
Hi @michael-s-molina. Can we rebase it from |
Hi @EugeneTorap. This draft is only meant to be a POC. We just merged #21094 and now the next step is to add Select All to the sync version. Async support will come next, in a different PR than this one. I'll close this PR to avoid further confusion. The Select All in Explore is a specific case and there's a discussion about it being conducted by @kasiazjc @cccs-RyanK. Here we're focusing more on the generic feature for all selects. @kasiazjc @cccs-RyanK I would appreciate it if you could post the discussion thread or any doc reference so that @EugeneTorap can participate. |
SUMMARY
This PR aims to add the "Select all" feature to the Select component. Adding this feature to a synchronous Select is really simple. The problem arises when adding "Select all" to an asynchronous, paginated, searchable, and keep selected on top Select. We have many technical challenges and design considerations as you can see here. Some of the requirements we need to address:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-05-20.at.8.57.20.AM.mov
TESTING INSTRUCTIONS
TODO
ADDITIONAL INFORMATION