Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable pylint error breaking CI #14506

Merged
merged 2 commits into from
May 6, 2021
Merged

fix: disable pylint error breaking CI #14506

merged 2 commits into from
May 6, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 6, 2021

SUMMARY

CI is broken because of W0125: Using a conditional statement with a constant value (using-constant-test) from pylint

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #14506 (35cd64e) into master (96289e9) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14506      +/-   ##
==========================================
- Coverage   77.14%   77.06%   -0.09%     
==========================================
  Files         958      958              
  Lines       48241    48241              
  Branches     5636     5636              
==========================================
- Hits        37217    37178      -39     
- Misses      10823    10862      +39     
  Partials      201      201              
Flag Coverage Δ
hive 80.80% <ø> (ø)
javascript 72.01% <ø> (ø)
mysql 81.06% <ø> (ø)
postgres 81.09% <ø> (ø)
presto ?
python 81.47% <ø> (-0.16%) ⬇️
sqlite 80.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/dashboard.py 77.98% <ø> (ø)
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.48%) ⬇️
superset/connectors/sqla/models.py 88.61% <0.00%> (-1.46%) ⬇️
superset/models/core.py 88.85% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96289e9...35cd64e. Read the comment docs.

@hughhhh hughhhh merged commit 1df9384 into master May 6, 2021
@etr2460
Copy link
Member

etr2460 commented May 6, 2021

Thanks for fixing this, not sure why i didn't see the CI failures on my branch

@dpgaspar dpgaspar deleted the fix-pylint branch May 7, 2021 15:15
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants