From b7e7443de68f32f67dc2be79840092114b3f0967 Mon Sep 17 00:00:00 2001 From: samtfm Date: Mon, 22 Mar 2021 15:31:40 -0700 Subject: [PATCH 1/2] log errors for thumbnail generation as warnings --- superset/utils/screenshots.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/utils/screenshots.py b/superset/utils/screenshots.py index 73e0c8c12b691..ad92899538661 100644 --- a/superset/utils/screenshots.py +++ b/superset/utils/screenshots.py @@ -151,13 +151,13 @@ def compute_and_cache( # pylint: disable=too-many-arguments try: payload = self.get_screenshot(user=user, window_size=window_size) except Exception as ex: # pylint: disable=broad-except - logger.error("Failed at generating thumbnail %s", ex) + logger.warning("Failed at generating thumbnail %s", ex, ex_info=True) if payload and window_size != thumb_size: try: payload = self.resize_image(payload, thumb_size=thumb_size) except Exception as ex: # pylint: disable=broad-except - logger.error("Failed at resizing thumbnail %s", ex) + logger.warning("Failed at resizing thumbnail %s", ex, ex_info=True) payload = None if payload: From 50c48f04ecb831d9a8860eead8c203f2b8d3d1c5 Mon Sep 17 00:00:00 2001 From: samtfm Date: Tue, 30 Mar 2021 14:17:49 -0700 Subject: [PATCH 2/2] fix: ex_info -> exc_info --- superset/utils/screenshots.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/utils/screenshots.py b/superset/utils/screenshots.py index ad92899538661..7c4d372414fc6 100644 --- a/superset/utils/screenshots.py +++ b/superset/utils/screenshots.py @@ -151,13 +151,13 @@ def compute_and_cache( # pylint: disable=too-many-arguments try: payload = self.get_screenshot(user=user, window_size=window_size) except Exception as ex: # pylint: disable=broad-except - logger.warning("Failed at generating thumbnail %s", ex, ex_info=True) + logger.warning("Failed at generating thumbnail %s", ex, exc_info=True) if payload and window_size != thumb_size: try: payload = self.resize_image(payload, thumb_size=thumb_size) except Exception as ex: # pylint: disable=broad-except - logger.warning("Failed at resizing thumbnail %s", ex, ex_info=True) + logger.warning("Failed at resizing thumbnail %s", ex, exc_info=True) payload = None if payload: