-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): incorrect missing datasource condition #12758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your rush fix.
Codecov Report
@@ Coverage Diff @@
## master #12758 +/- ##
==========================================
- Coverage 66.77% 61.31% -5.47%
==========================================
Files 1021 533 -488
Lines 50015 19879 -30136
Branches 4907 4907
==========================================
- Hits 33396 12188 -21208
+ Misses 16494 7490 -9004
- Partials 125 201 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...
SUMMARY
Fix a regression introduced by #12705 , where I accidentally slipped in a wrong variable after some light refactoring while addressing PR comments.
Thought the change was harmless and didn't test enough.
Thanks for @zhaoyongjie for reporting this!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
"Missing Dataset" warning displayed even though dataset exits.
After
TEST PLAN
Manual verificagtion
closes #12757
ADDITIONAL INFORMATION