Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests errors and warnings - iteration 5 (#12212) #12224

Merged
merged 1 commit into from
Jan 26, 2021
Merged

fix: tests errors and warnings - iteration 5 (#12212) #12224

merged 1 commit into from
Jan 26, 2021

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Dec 29, 2020 •
edited
Loading

SUMMARY

Remove tests errors and warnings to improve results readability.

The following errors and warnings have been removed:

Unmatched <HTTP_METHOD> to <URL>

spec/javascripts/datasource/DatasourceModal_spec.jsx

Warning: Failed prop type: The prop `savedMetric.metric_name` is marked as required, 
but its value is `undefined`.

spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx
spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx

Item with key "test" already exists. You are assigning a new value.

spec/javascripts/explore/components/ColorPickerControl_spec.jsx

Warning: Failed prop type: The prop `actions` is marked as required, but its value is `null`.

spec/javascripts/explore/components/DatasourcePanel_spec.jsx

Warning: Failed prop type: The prop `chartHeight` is marked as required, 
but its value is `undefined`.

spec/javascripts/explore/components/ExploreChartHeader_spec.jsx

Warning: Failed prop type: The prop `chart.id` is marked as required, 
but its value is `undefined`.

spec/javascripts/explore/components/ExploreChartHeader_spec.jsx

Warning: Failed prop type: Invalid prop `option` supplied to `MetricDefinitionOption`.

spec/javascripts/explore/components/MetricDefinitionOption_spec.jsx
spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx

Warning: Failed prop type: The prop `index` is marked as required, 
but its value is `undefined`.

spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx

Warning: Failed prop type: The prop `onMetricEdit` is marked as required, 
but its value is `undefined`.

spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx

Warning: Failed prop type: The prop `savedMetric.expression` is marked as required, 
but its value is `undefined`.

spec/javascripts/explore/components/MetricDefinitionValue_spec.jsx

Warning: Failed prop type: The prop `displayLimit` is marked as required, 
but its value is `undefined`.

spec/javascripts/sqllab/SqlEditor_spec.jsx

#12212

@rusackas @junlincc @villebro

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas added the hold! On hold label Jan 6, 2021
@michael-s-molina michael-s-molina force-pushed the fix-tests-errors-warnings-5 branch from b982b55 to 22adacb Compare January 20, 2021 13:56
@codecov-io
Copy link

codecov-io commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #12224 (0802770) into master (a422c76) will decrease coverage by 3.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12224      +/-   ##
==========================================
- Coverage   66.79%   63.25%   -3.55%     
==========================================
  Files        1015      486     -529     
  Lines       49676    29984   -19692     
  Branches     4847        0    -4847     
==========================================
- Hits        33183    18965   -14218     
+ Misses      16371    11019    -5352     
+ Partials      122        0     -122
Flag Coverage Δ
cypress ?
javascript ?
python 63.25% <ø> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 62.69% <0.00%> (-24.88%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/db_engine_specs/presto.py 73.37% <0.00%> (-8.66%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/db_engine_specs/base.py 79.59% <0.00%> (-6.38%) ⬇️
superset/views/database/forms.py 83.33% <0.00%> (-5.56%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
... and 533 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2463215...0802770. Read the comment docs.

@michael-s-molina michael-s-molina force-pushed the fix-tests-errors-warnings-5 branch from 22adacb to 0802770 Compare January 20, 2021 18:48
@rusackas rusackas removed the hold! On hold label Jan 25, 2021
rusackas
rusackas approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 22d52ea into apache:master Jan 26, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 26, 2021
Merge branch 'master' into feat/dashboard_access_roles
1d3e3ae 
* master: (52 commits)
  docs: Updates to Superset Site for 1.0 (apache#12626)
  test(native-filters): scoping tree in native filters modal (apache#12655)
  Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219)
  Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224)
  Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227)
  feat(native-filters): apply scoping of native filters to dashboard (apache#12716)
  Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223)
  Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245)
  fix: missing select menu background (apache#12759)
  fix(explore): incorrect missing datasource condition (apache#12758)
  feat: default timepicker to last week when dataset is changed (apache#12609)
  feat(explore): allow opening charts with missing dataset (apache#12705)
  chore: upgrade Cypress to 6.2.1 (apache#12605)
  refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218)
  feat: Adding option to set_database_uri CLI command (apache#12740)
  docs: Fixed typo on line 348 (apache#12739)
  Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214)
  docs: Remove gatsby-plugin-offline (apache#12693)
  test: oracle engine spec (apache#12615)
  test: hive db engine spec (apache#12520)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-s-molina @codecov-io @rusackas @junlincc