Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Big Number with Trendline ] sql bug #9071

Closed
zhxjdwh opened this issue Feb 3, 2020 · 2 comments
Closed

[Big Number with Trendline ] sql bug #9071

zhxjdwh opened this issue Feb 3, 2020 · 2 comments

Comments

@zhxjdwh
Copy link
Contributor

zhxjdwh commented Feb 3, 2020

the [Big Number with Trendline ] generated sql ,
the where sql should be timecol >= beginTime and timecol < endTime ,
but in superset-0.34.0,
the where sql is : timecol >= beginTime and timecol <= endTime ,

Expected results

where timecol >= beginTime and timecol < endTime

Actual results

Screenshots

TIM图片20200203005037

How to reproduce the bug

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Environment

(please complete the following information):

  • superset version: superset version
    superset-0.34.0
  • python version: python --version
  • node.js version: node -v
  • npm version: npm -v

Checklist

Additional context

@john-bodley
Copy link
Member

@zhxjdwh this issue is described in SIP-15 and a solution was introduced in 0.36. To enable it you will have to set the SIP_15_ENABLED flag to True. Note in master the default value is now True.

@zhxjdwh
Copy link
Contributor Author

zhxjdwh commented Feb 4, 2020

@john-bodley thanks

@zhxjdwh zhxjdwh closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants