-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate tslint in favor of eslint w/ typescript support #8865
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
🏷 frontend |
cc @williaster and @kristw for their opinions. Also, have you considered looking into the build configs in the superset-ui-plugins and superset-ui repos and seeing if they make sense here? |
Those repositories use |
standardizing on the |
Having recently written some typescript in the repo I found the tslint rules to be very strict. Rules like alphabetizing object keys, not allowing lambdas in jsx, not allowing multiline expressions in jsx, among others don't coincide with the eslint rules and are not autofixable. Spending time fixing these is tedious and does not encourage use of typescript.
In order to increase adoption of typescript in the repo I think it would be good to have the typescript developer experience to be as closer to the current javascript experience. Also, it looks like the creators of tslint are recommending not using that library anymore.
We should configure eslint to support typescript and try to have as many of the same rules in both environments as possible. Info on how to implement this: https://codeburst.io/from-eslint-to-tslint-and-back-again-bf259c2e7437
The text was updated successfully, but these errors were encountered: