Sqllab row limit controls don't get applied

[michellethomas]

Row limit controls in sqllab don't get applied. As noted in this PR if your DEFAULT_SQLLAB_LIMIT is 1000 and in the UI you set the row limit to 5000, 1000 rows will be shown in the UI instead of 5000.

We tried to resolve this in the above PR by removing the display limit but could not get consensus on that approach. If people feel strongly about having a DEFAULT_SQLLAB_LIMIT, and a SQL_MAX_ROW we can allow SQL_MAX_ROW to be None if a deployment doesn't want to set a max.

Setting this to P1 bug because the UI is not showing correct information to the user based on the controls.

Expected results

Changing the row limit in the UI

Actual results

Changing the row limit does not get applied instead DEFAULT_SQLLAB_LIMIT is shown

How to reproduce the bug

1. Go to sqllab
2. Click on limit control
3. Run query
4. Check that data shown in UI is not the same as in csv download

Environment

(please complete the following information):

• superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Related bugs: #7310, #6666

@mistercrunch @john-bodley

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.80. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.